Ember fixes #115
Ember fixes #115
Conversation
src/api/import.js
Outdated
| @@ -205,10 +206,11 @@ export default async (providedOptions = {}) => { | |||
| }), null, 2)); | |||
| }); | |||
|
|
|||
| console.info('NOTE: You might be able to remove your `.compilerc` file completely if you are only using the `es2015` and `react` presets'.yellow); | |||
| if (interactive) console.info('NOTE: You might be able to remove your `.compilerc` file completely if you are only using the `es2015` and `react` presets'.yellow); // eslint-disable-line max-len | |||
There was a problem hiding this comment.
Perhaps we can do a similar thing to Packager here:
function info (interactive, message) {
if (interactive) {
console.info(message)
}
}Same with warn.
src/api/make.js
Outdated
| @@ -49,19 +49,18 @@ export default async (providedOptions = {}) => { | |||
| }); | |||
|
|
|||
| if (platform && platform !== process.platform && !(process.platform === 'darwin' && platform === 'mas')) { | |||
| console.error('You can not "make" for a platform other than your systems platform'.red); | |||
| process.exit(1); | |||
| throw 'You can not "make" for a platform other than your systems platform'; | |||
There was a problem hiding this comment.
throw "You cannot run 'make' for a platform other than your system's platform";| d('installing devDependencies'); | ||
| await installDepList(dir, devDeps, true); | ||
| d('installing electron-prebuilt-compile'); | ||
| await installDepList(dir, [`electron-prebuilt-compile@${electronVersion || 'latest'}`], false, true); |
There was a problem hiding this comment.
I had to check for myself what happened when you ran npm install --save --exact electron-prebuilt-compile@latest but it does what we want 👍
|
Also it would be kind of nice if there was a test for the |
|
@malept We don't have any import tests yet (need to come up with a templatey bootstrapping thing to test it) |
|
@malept Travis CI is currently under ridiculous load. If you're OK with the PR we can merge it. I've run the test suite locally on macOS |
|
❤️ you all. Thanks @MarshallOfSound @malept 😄 |
|
@MarshallOfSound feel free to release a new version, I don't think I'll have time to do that today. |
chore: Updates for everyone
Fixes #111
Fixes #112
Fixes #114
Fixes #108
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Are your changes appropriately documented?
Yes
Do your changes have sufficient test coverage?
N/A
Does the testsuite pass successfully on your local machine?
Yes
Summarize your changes:
Fix the things 😆
Pretty straight forward
process.exitcalls 'cos that's just plain wrongimportAPI forupdateScriptselectronVersionto@latest