Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API option to suppress console output #111

Closed
malept opened this issue Jan 30, 2017 · 3 comments
Closed

Add API option to suppress console output #111

malept opened this issue Jan 30, 2017 · 3 comments

Comments

@malept
Copy link
Member

malept commented Jan 30, 2017

Initially from @anulman in #108:

Option to suppress console output: ember-electron should be able to provide its own messaging to the end user; comments about "converting CLI / grunt / etc scripts yourself" and preload script handling are inaccurate given our use (relevant source)

This should ultimately be a common option in all of the API endpoints.

Similar PR (but for Packager): electron/packager#541

@MarshallOfSound
Copy link
Member

@malept Is this separate to the interactive flag or do we just need to make console.log and such follow the interactive setting?

@malept
Copy link
Member Author

malept commented Jan 30, 2017

@MarshallOfSound I'd have to see how we use interactive all over, but that may well be the case.

@anulman
Copy link
Contributor

anulman commented Jan 30, 2017

If we're looking at this as coupled with interactive, what do you think of moving the api-level interactive code up to the command layer (i.e. electron-forge-import.js vs api/import.js)?

From what I've read in api/start and api/import, it seems you use interactive to prepare options for the build tools beneath. Could it be considered the native / default consumer of the api fns?

Very curious what you think. I'm still getting familiar with Forge's nooks & boundaries :)

malept pushed a commit that referenced this issue Feb 1, 2017
dsanders11 pushed a commit that referenced this issue Jan 14, 2023
fix: friendlier button text for intro tour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants