Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete MXCryptoV2 implementation #6985

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Complete MXCryptoV2 implementation #6985

merged 4 commits into from
Oct 31, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 26, 2022

Conform to the latest SDK changes mostly consisting in changes of nullability in MXCrypto protocol and MXLegacyCrypto typecasing for functionality not supported by Crypto V2 (or handled internally by MXCryptoMachine)

@Anderas Anderas requested review from a team and phloux and removed request for a team October 26, 2022 16:04
Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas mentioned this pull request Oct 31, 2022
@Anderas Anderas merged commit 5450a68 into develop Oct 31, 2022
@Anderas Anderas deleted the andy/complete_crypto branch October 31, 2022 17:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants