Complete MXCryptoV2 implementation #1620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large final round of changes to the
MXCryptoV2
implementation to make it ready for alpha testing. The changes in this PR include:MXCrypto
protocol and intoMXLegacyCrypto
implementation, as they are not needed with V2 (the functionality is handled internally byCryptoMachine
)MXCrypto
with nullability to make swift code safer and more explicit. At times this means making more things nullable than necessary just to handle any rogue objective-cnil
sMatrixSDKCrypto
to the latest version which includesEncryptionSetting
MXCryptoV2
to group related functionality (apologies for impact on code review)