Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback for poll ended event (PSG-1156) #7353

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

alfogrillo
Copy link
Contributor

Description

This PR:

  • Adds a fallback text for m.poll.end events. These fallbacks are useful for receivers when the associated m.poll.start event is unavailable. (see screenshots below)
  • Fixes a bug that prevented to see the last "poll ended" event in the room list

Dependency

matrix-org/matrix-ios-sdk#1713

Result

Plain Bubble
normal bubble

|

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 12.08% // Head: 12.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (aab905f) compared to base (398f0c2).
Patch coverage: 12.50% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7353   +/-   ##
========================================
  Coverage    12.08%   12.09%           
========================================
  Files         1637     1638    +1     
  Lines       161848   161887   +39     
  Branches     66439    66456   +17     
========================================
+ Hits         19566    19576   +10     
- Misses      141636   141664   +28     
- Partials       646      647    +1     
Flag Coverage Δ
uitests 55.34% <0.00%> (-0.04%) ⬇️
unittests 5.97% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Models/Room/MXKSendReplyEventStringLocalizer.swift 0.00% <0.00%> (ø)
.../Styles/Bubble/Cells/Poll/PollBaseBubbleCell.swift 0.00% <0.00%> (ø)
...imelinePoll/Coordinator/TimelinePollProvider.swift 0.00% <0.00%> (ø)
...om/TimelinePoll/View/TimelinePollMessageView.swift 0.00% <0.00%> (ø)
Riot/Modules/MatrixKit/Models/MXKAppSettings.m 36.63% <100.00%> (+0.19%) ⬆️
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 17.00% <100.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...es/Room/VoiceMessages/VoiceMessageController.swift 0.00% <0.00%> (ø)
...odules/Room/PollHistory/View/SegmentedPicker.swift 58.92% <0.00%> (+22.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@alfogrillo alfogrillo merged commit 062789d into develop Feb 10, 2023
@alfogrillo alfogrillo deleted the alfogrillo/fallback_poll_ended_event branch February 10, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants