Add fallback text for m.poll.end events (PSG-1156) #1713
Conversation
alfogrillo
requested review from
a team and
Anderas
and removed request for
a team
Codecov ReportBase: 37.38% // Head: 37.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1713 +/- ##
===========================================
- Coverage 37.38% 37.37% -0.02%
===========================================
Files 612 612
Lines 95958 95961 +3
Branches 41471 41471
===========================================
- Hits 35876 35866 -10
- Misses 59032 59046 +14
+ Partials 1050 1049 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -44,7 +44,7 @@ - (instancetype)init | |||
| _senderSentTheirLocation = @"has shared their location."; | |||
| _senderSentTheirLiveLocation = @"Live location."; | |||
| _messageToReplyToPrefix = @"In reply to"; | |||
| _replyToEndedPoll = @"Ended poll"; | |||
| _endedPollMessage = @"Ended poll"; | |||
There was a problem hiding this comment.
These strings do not live in the regular localized strings file?
There was a problem hiding this comment.
Yes, generally clients can override them if they wish.
In this context they are meant to be not localized since we don't want to localize stuff from the sender side when sending an event.
Description
This PR adds a fallback text for
m.poll.endevents.These fallbacks are useful for receivers when the associated
m.poll.startevent is unavailable.