Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID server access token not included when making a 3pid invite #22757

Closed
richvdh opened this issue Jul 6, 2022 · 4 comments · Fixed by matrix-org/matrix-js-sdk#2503
Closed

ID server access token not included when making a 3pid invite #22757

richvdh opened this issue Jul 6, 2022 · 4 comments · Fixed by matrix-org/matrix-js-sdk#2503
Assignees
@turt2live
Labels
A-3PIDs A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Spec-Compliance An area where Element doesn't correctly implement the spec

Comments

@richvdh
Copy link
Member

richvdh commented Jul 6, 2022

Steps to reproduce

Send an invite to a third-party id (eg an email address)

Outcome

What did you expect?

id_access_token should be included, since the spec requires it

What happened instead?

No id_access_token parameter

Operating system

No response

Application version

1.11.0

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@richvdh
Copy link
Member Author

richvdh commented Jul 6, 2022

We're planning to drop support for 3pid invite requests (via both POST /_matrix/client/v3/rooms/{roomId}/invite and POST /_matrix/client/v3/createRoom) without an id_access_token, because we need to know that a user has accepted the IS'es terms before we use it (cf matrix-org/synapse#13206, matrix-org/sydent#338).

@richvdh richvdh mentioned this issue Jul 6, 2022
Closed
@turt2live turt2live self-assigned this Jul 7, 2022
@turt2live
Copy link
Member

so we have all the code which makes this work, but we forgot to copy the IdentityServerProvider over to the MatrixClient, so it thinks it doesn't need to supply an access token 🤦

@turt2live turt2live added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Invite A-3PIDs Z-Spec-Compliance An area where Element doesn't correctly implement the spec O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 7, 2022
@turt2live turt2live mentioned this issue Jul 7, 2022
Merged
@turt2live
Copy link
Member

unclear when this regressed, but my guess would be when the file got converted to typescript

@richvdh
Copy link
Member Author

richvdh commented Jul 11, 2022

Thanks for jumping on this so quickly @turt2live !

su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Aug 1, 2022
@su-ex
Merge tag 'v19.1.0' into sc
d0951b8 
* Remove MSC3244 support ([\matrix-org#2504](matrix-org#2504)).
* `room` now exports `KNOWN_SAFE_ROOM_VERSION` ([\matrix-org#2474](matrix-org#2474)).
* Don't crash with undefined room in `processBeaconEvents()` ([\matrix-org#2500](matrix-org#2500)). Fixes matrix-org#2494.
* Properly re-insert room ID in bundled thread relation messages from sync ([\matrix-org#2505](matrix-org#2505)). Fixes element-hq/element-web#22094. Contributed by @duxovni.
* Actually store the identity server in the client when given as an option ([\matrix-org#2503](matrix-org#2503)). Fixes element-hq/element-web#22757.
* Fix call.collectCallStats() ([\matrix-org#2480](matrix-org#2480)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-3PIDs A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Spec-Compliance An area where Element doesn't correctly implement the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Actually store the identity server in the client when given as an option matrix-org/matrix-js-sdk
2 participants
@turt2live @richvdh