Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on processBeaconEvents due to null room in notificationTimeline #2494

Closed
sdb-dev opened this issue Jul 5, 2022 · 0 comments · Fixed by #2500
Closed

Crash on processBeaconEvents due to null room in notificationTimeline #2494

sdb-dev opened this issue Jul 5, 2022 · 0 comments · Fixed by #2500
Assignees
@SimonBrandner
Labels
T-Defect

Comments

@sdb-dev
Copy link

sdb-dev commented Jul 5, 2022 •
edited
Loading

Describe the bug
When loading the client timeline set data, processBeaconEvents is called on the matrix events for the notification timeline. However, notification timeline has no room associated with it.

The processBeaconEvents function expects a room if there are any matrix events.

Here is the callback on the sync event:
image

And the call to processBeaconEvents:
image

To Reproduce
Steps to reproduce the behavior:
Create / start the client
Create a notification timelineset
Request timeline notifications

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 103

This is not an issue in version 16 of the SDK. It is present in 17, 18, and 19.
@SimonBrandner SimonBrandner self-assigned this Jul 7, 2022
@SimonBrandner SimonBrandner mentioned this issue Jul 7, 2022
Merged
@gleachkr gleachkr mentioned this issue Jul 11, 2022
Closed
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Aug 1, 2022
@su-ex
Merge tag 'v19.1.0' into sc
d0951b8 
* Remove MSC3244 support ([\matrix-org#2504](matrix-org#2504)).
* `room` now exports `KNOWN_SAFE_ROOM_VERSION` ([\matrix-org#2474](matrix-org#2474)).
* Don't crash with undefined room in `processBeaconEvents()` ([\matrix-org#2500](matrix-org#2500)). Fixes matrix-org#2494.
* Properly re-insert room ID in bundled thread relation messages from sync ([\matrix-org#2505](matrix-org#2505)). Fixes element-hq/element-web#22094. Contributed by @duxovni.
* Actually store the identity server in the client when given as an option ([\matrix-org#2503](matrix-org#2503)). Fixes element-hq/element-web#22757.
* Fix call.collectCallStats() ([\matrix-org#2480](matrix-org#2480)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't crash with undefined room in processBeaconEvents() matrix-org/matrix-js-sdk
2 participants
@sdb-dev @SimonBrandner