Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2059 ringbuffers on gpdma #2302

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

tyler-gilbert
Copy link
Contributor

No description provided.

@tyler-gilbert
Copy link
Contributor Author

I still need to do some additional testing on the STM32U545 and STM32F429 before this is ready to merge.

@tyler-gilbert
Copy link
Contributor Author

Everything is working on STM32U545. Need to check STM32F429 before merging.

@tyler-gilbert
Copy link
Contributor Author

Tested and working on STM32F429 also (with dma). Not tested with BDMA but that has the same API as DMA. The only thing this adds to BDMA is the async stop and the write_immediate to pre-fill the buffer.

@tyler-gilbert
Copy link
Contributor Author

Should be ready for review and to merge.

@tyler-gilbert
Copy link
Contributor Author

@xoviat @Dirbaio

Please let me know if this needs anything else.

@Dirbaio
Copy link
Member

Dirbaio commented Jan 1, 2024

This PR has quite a bit of unrelated things mixed:

  • GPDMA ringbuffer support.
  • New APIs stop and write_immediate.
  • U5 RCC support for PLLP/Q
  • SAI changes

Could you split them all in separate PRs, so we can discuss/review them independently?

Also, please rebase so you don't add merge commits to the history.

Additionally, now that this adds ringbuffers on GPDMA, we should enable the ringbuffered uart test for it. Could you do it?

@tyler-gilbert
Copy link
Contributor Author

@Dirbaio,

Sounds good. I will work on that.

@tyler-gilbert
Copy link
Contributor Author

STM32 U5 changes moved to: #2396
Add write_immediate() function: #2397
Add stop() function: #2399

I will create another MR with the GPDMA ring buffers once the above are merged. Then one more MR to address the tweaks to the SAI driver that add the write_immediate() and stop() functions.

@elagil
Copy link
Contributor

elagil commented Sep 6, 2024

@tyler-gilbert Interested in this as well, what is holding it back at the moment?
I can test on STM32H5 and H7 and maybe contribute something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants