-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Canary Builds #6010
Comments
@ryanto we are working to setup similar canary publishing as yes, we require a publishing step now prior to consumption |
Might be able to do something like: {
name: 'ember-canary',
npm: {
devDependencies: {
'ember-source': urls[2],
'ember-data-mono': 'emberjs/data',
'ember-data': 'file:./node_modules/ember-data-mono/packages/ember-data',
},
resolutions: {
'ember-data/@ember-data/store': 'file:./node_modules/ember-data-mono/packages/store',
'ember-data/@ember-data/adapter': 'file:./node_modules/ember-data-mono/packages/adapter',
'ember-data/@ember-data/model': 'file:./node_modules/ember-data-mono/packages/model',
'ember-data/@ember-data/serializer': 'file:./node_modules/ember-data-mono/packages/serializer',
}
}
} Kinda just spit-ballin' though... |
@rwjblue I've tried out your idea in an app. There are two issues that prevent it from working:
|
The After a bit of discussion, @rwjblue and I feel it may be time to begin publishing canary builds to Note that the data team needs to begin publishing Some background: previous complaints included
|
@runspired I can't think of any objections to a canary tag in npm, but I also admit to not being aware of all the nuances involved. |
Last I checked, when npm/yarn do the actual resolution, they still must download the complete entry, are we concerned this entry will grow? If this contained 6000+ canary versions, would this impact dependency installation time? On another note, was this already discussed as part of the effort to convert to a mono-repo? If so, could that discussion be linked? |
Yes, overall time would increase (a pretty small amount of time as a percentage of the overall time for the command) but only for the person regenerating the |
it was not previously discussed. There was an assumption we'd do something similar to ember-source but unlike ember-source we have actual packages and so that process is a bit more complicated. In light of that consideration, we decided to explore whether the simple-thing of "just use the ecosystem" wouldn't be the best approach.
Typescript has over a thousand at this time and the a precursory check seems to suggest this isn't a major issue. Granted the below smoke-test would resolve to For a project with no dependencies and no lock file (empty package.json) we find comparing installation of
For reference,
|
After discussing with @krisselden @kategengler and @stefanpenner out-of-band there appears to be broad agreement that publishing to
This is in-line with my own understanding of what we wanted to achieve (a daily publish, not a per-commit publish). |
resolved by #6074 We now publish a nightly canary and weekly beta to
|
Trying out the new beta release and it's working well but am seeing the following messages:
The app seems to be working fine, but is there anything to be done about the above? |
Yes, we need to fix the warnings. @richard-viney mind reporting a specific issue (after double checking that one isn't already tracking this)? |
@richard-viney @rwjblue ostensibly this is a subtask of fixing our rollup step which has an issue already |
`ember-data` is a monorepo now, so these kinds of version constraint declarations won't work anymore. see emberjs/data#6010
* ember-try: Fix broken `ember-data` dependency declarations `ember-data` is a monorepo now, so these kinds of version constraint declarations won't work anymore. see emberjs/data#6010 * CI: Use default dependencies for default scenarios The `latest` version of ember-data (v3.11) is using async/await in Node.js code, but since we run CI on Node.js 6 it does not support that yet. This means we will have to use an older version of ember-data for now until we drop support for Node.js 6. * CI: Allow failures for `ember-beta` scenario see previous commit about async/await usage in recent ember-data releases * package.json: Pin `cssstyle` to v1.2.x see jsdom/cssstyle#95 * package.json: Pin `ember-data` to v3.7.x Using `^3.0.0` currently resolves to v3.11.x which is not compatible with Node.js 6 anymore. v3.8.x and above have some other issues so we will use v3.7.x until we figure those out. * Revert "Build(deps-dev): bump mermaid from 7.1.2 to 8.0.0 (#1765)" This reverts commit 95ae7cb. Some dependencies of `mermaid@8` are incompatible with Node.js 6
Hey there!
Currently in my ember-try config I'm testing against Ember Data's github repo as a way to simulate a canary scenario.
I noticed that Ember Data recently switched over to a mono repo, which means no more npm installs from github.
I'm wondering if a canary build of Ember Data gets published anywhere (similar to what ember-source does)?
Also, looking for advice on how to best approach this problem, since there's probably a better way that I'm not aware of.
As always, thanks!
The text was updated successfully, but these errors were encountered: