Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #95

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Update all dependencies #95

merged 2 commits into from
Jul 1, 2019

Conversation

jsakas
Copy link
Member

@jsakas jsakas commented Jul 1, 2019

Update all dependencies including CCSOM which looks like its gotten a few releases.
Drop support for Node 6. Its reached EOL - https:/nodejs/Release

@jsakas jsakas merged commit 1e8ebe0 into master Jul 1, 2019
@jsakas jsakas deleted the upgrade-deps-1907 branch July 1, 2019 15:03
@Turbo87
Copy link

Turbo87 commented Jul 4, 2019

@jsakas this should be considered a breaking change and requires a major version bump. every package that was working fine with v1.2.x and Node.js 6 is currently breaking because v1.3.0 is no longer compatible with Node.js 6.

Turbo87 added a commit to Turbo87/ember-simple-auth that referenced this pull request Jul 4, 2019
marcoow pushed a commit to mainmatter/ember-simple-auth that referenced this pull request Jul 4, 2019
* ember-try: Fix broken `ember-data` dependency declarations

`ember-data` is a monorepo now, so these kinds of version constraint declarations won't work anymore. see emberjs/data#6010

* CI: Use default dependencies for default scenarios

The `latest` version of ember-data (v3.11) is using async/await in Node.js code, but since we run CI on Node.js 6 it does not support that yet. This means we will have to use an older version of ember-data for now until we drop support for Node.js 6.

* CI: Allow failures for `ember-beta` scenario

see previous commit about async/await usage in recent ember-data releases

* package.json: Pin `cssstyle` to v1.2.x

see jsdom/cssstyle#95

* package.json: Pin `ember-data` to v3.7.x

Using `^3.0.0` currently resolves to v3.11.x which is not compatible with Node.js 6 anymore. v3.8.x and above have some other issues so we will use v3.7.x until we figure those out.

* Revert "Build(deps-dev): bump mermaid from 7.1.2 to 8.0.0 (#1765)"

This reverts commit 95ae7cb.

Some dependencies of `mermaid@8` are incompatible with Node.js 6
@SimenB
Copy link

SimenB commented Jul 13, 2019

@jsakas any chance of reverting the changes in 1.3.0 and releasing a new major? This causes downstream issues (in jest via jsdom in my case)

@stephtr
Copy link

stephtr commented Jul 14, 2019

@SimenB why not just deprecate Node.js 6 support for jest since it already has reached its End-of-life?

@SimenB
Copy link

SimenB commented Jul 14, 2019

Sure, we'll drop it in the next major release. But that doesn't mean it should be dropped in a minor release of some transitive dependency

@stephtr
Copy link

stephtr commented Jul 14, 2019

Ah sorry yes, I read your comment too quickly.

@jsakas
Copy link
Member Author

jsakas commented Jul 14, 2019

@SimenB seems like this is causing a lot of issues in the community, my apologies.

What would be the proper way to resolve this? I'm thinking

  • Re-release 1.2.x as 1.4.0
  • Re-release 1.3.0 as 2.0.0

Let me know.

@SimenB
Copy link

SimenB commented Jul 14, 2019

Yeah, doing those seems like the perfect fix!

@SimenB
Copy link

SimenB commented Jul 15, 2019

Oh, and maybe deprecate 1.3.0 saying it was an unintentional breaking change? No biggie either way, though 🙂

@jsakas
Copy link
Member Author

jsakas commented Jul 15, 2019

Thanks @SimenB - this is done.

We now have v2.0.0 (master branch), and v1.4.0 (v1 branch)

v1.3.0 has been deprecated on the npm registry.

@SimenB
Copy link

SimenB commented Jul 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants