System.exit does proper context hard exit. #10363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From cmd line.
Akirathan
added
the
CI: No changelog needed
Akirathan
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
hubertp
as code owners
radeusgd
reviewed
Jul 15, 2024
engine/runtime/src/main/java/org/enso/interpreter/runtime/system/System.java
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Jul 15, 2024
GregoryTravis
approved these changes
Jul 15, 2024
…em/System.java Co-authored-by: Radosław Waśko <[email protected]>
JaroslavTulach
requested changes
Jul 15, 2024
There was a problem hiding this comment.
- The
ExitExceptionshould implement getExceptionExitStatus - I'd like to understand what is the benefit of using
ctx.exitover (improved)ExitException
engine/runtime/src/main/java/org/enso/interpreter/runtime/system/System.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/service/error/ExitException.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
requested changes
Jul 17, 2024
engine/runtime/src/main/java/org/enso/interpreter/service/error/ExitException.java
Outdated
Show resolved
Hide resolved
...ment-common/src/main/scala/org/enso/interpreter/instrument/job/ProgramExecutionSupport.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/service/error/ExitException.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/service/error/ExitException.java
Outdated
Show resolved
Hide resolved
| @@ -880,8 +880,12 @@ private void runMain( | |||
| } | |||
| } | |||
| } catch (PolyglotException e) { | |||
| printPolyglotException(e, rootPkgPath); | |||
| throw exitFail(); | |||
| if (e.isExit()) { | |||
There was a problem hiding this comment.
Possibly we might close the context here to notify other language runtimes that the shutdown is happening... not very urgent.
Also make ExitException package-private.
JaroslavTulach
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9872
Pull Request Description
The
System.exit 42component is treated the same way as any other Panic error - it does not interfere with other component evaluation:After removing the
System.exit 42component, the workflow works as expected. I have also tried opening the project with the component and then removing it.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
System.exitin a workflow in IDE and make sure it is usable after that.