-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate WithWarnings
to use EnsoHashMap
to speed them up significantly
#8682
Comments
Pavel Marek reports a new STANDUP for today (2024-07-16): Progress: - Collect profiling from benchmarks to see the real hotspots of
|
Pavel Marek reports a new STANDUP for today (2024-07-17): Progress: - Migrated |
I cannot say why that's the case. I believe your approach is correct, Pavel. |
Pavel Marek reports a new STANDUP for yesterday (2024-07-18): Progress: - Continue investigation of performance issues on |
Pavel Marek reports a new STANDUP for today (2024-07-19): Progress: - Let's not remove
|
Pavel Marek reports a new STANDUP for today (2024-07-22): Progress: - Still working on the |
Pavel Marek reports a new STANDUP for today (2024-07-23): Progress: - Fixed all the tests for the newly introduced
|
Pavel Marek reports a new STANDUP for today (2024-07-24): Progress: - Starting to analyze the performance. The warnings benchmark is so far twice as slow as it used to be.
|
Pavel Marek reports a new STANDUP for today (2024-07-25): Progress: - reassignments of warnings are the most costly and most frequent operation and they server no purpose, let's remove them.
|
Pavel Marek reports a new STANDUP for today (2024-07-26): Progress: - Debugging performance - looking into IGV graphs, experimenting with profiles.
|
Pavel Marek reports a new STANDUP for today (2024-07-29): Progress: - Discovered std lib benchmark regression (#10702)
|
Pavel Marek reports a new STANDUP for yesterday (2024-07-29): Progress: - JPMS help on #10714
|
Pavel Marek reports a new STANDUP for today (2024-07-31): Progress: - More JPMS help
|
Pavel Marek reports a new STANDUP for today (2024-08-05): Progress: - Finally reveal the worst bottleneck. The benchmark results are now 10x better than on develop.
|
Pavel Marek reports a new STANDUP for today (2024-08-06): Progress: - Tests seem OK, scheduling benchmarks on this PR and tomorrow, will compare the results. It should be finished by 2024-08-07. |
This is a long time open task that keeps popping up from time to time. For example again in
The task has been hidden as a future checkbox in #5233, but apparently it is so hidden there it deserves its own issue.
WithWarnings uses EconomicMap implementation which (despite its good name) doesn't deliver on it promise as it cannot be partially evaluated and has to be hidden behind
@TruffleBoundary
. That slows things down by magnitudes as Greg's benchmark also indicate.Since
there is a better way. Replace
EconomicMap
with direct use ofEnsoHashMap
(which is carefully designed to be PE friendly) and things will get lightening fast!The text was updated successfully, but these errors were encountered: