Store FramePointer in IR

[Akirathan]

Fixes #10129

Pull Request Description

Adds a new compiler pass FramePointerAnalysis that attaches [FramePointer]

enso/engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala

Line 386 in af1b7e8

class FramePointerMeta(

) metadata to various IR elements.

FramePointer metadata serves as a replacement for usage of AliasMetadata.Occurence in IrToTruffle.

There are still usages of AliasAnalysis metadata from IrToTruffle. Which means that alias metadata is still deserialized in IrToTruffle, and therefore, we will not see any big startup time improvements. To remove all usages of AliasAnalysis metadata in IrToTruffle, we need to think about how to remove all alias metadata references from LocalScope which seems like a big task for a follow-up PR.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.

[JaroslavTulach]

I don't see changes in IrToTruffle to use these new metadata. Those are essential in verifying the PR changes are correct.

[JaroslavTulach]

What does it mean?

org.graalvm.polyglot.PolyglotException: java.lang.UnsupportedOperationException: unimplemented, took 0.34 sec
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.compiler.pass.analyse.types.TypePropagation$CompilerNameResolution.assertLinkEquals(TypePropagation.java:394)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.compiler.pass.analyse.types.TypePropagation$CompilerNameResolution.assertLinkEquals(TypePropagation.java:336)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.compiler.context.NameResolutionAlgorithm.resolveName(NameResolutionAlgorithm.java:47)

at https:/enso-org/enso/actions/runs/10373180715/job/28717694507?pr=10729

GitHub

Store FramePointer in IR · enso-org/enso@6ec1ba6

Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

[JaroslavTulach]

The changes in IrToTruffle are good. We no longer need AliasAnalysis for computing FramePointer. Let's get this in.

However, as the primary goal was to speed things up, we need a away to create LocalScope without reading the alias graphs. Can we use Persistance.Reference there?

--- engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala
+++ engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala
@@ -31,8 +31,8 @@ import scala.jdk.CollectionConverters._
   */
 class LocalScope(
   final val parentScope: Option[LocalScope],
-  final val aliasingGraph: AliasGraph,
-  final val scope: AliasGraph.Scope,
+  final val aliasingGraph: Persistance.Reference[AliasGraph],
+  final val scope: Persistance.Reference[AliasGraph.Scope],
   final val dataflowInfo: DataflowAnalysis.Metadata,
   final val flattenToParent: Boolean                       = false,
   private val parentFrameSlotIdxs: Map[AliasGraph.Id, Int] = Map()

[JaroslavTulach]

We no longer need LocalScope to compute getFramePointer. That's good.

[Akirathan]

Follow-up task created in #10833