Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Frames not using the button post_url #461

Closed
neekolas opened this issue Jul 25, 2024 · 0 comments · Fixed by #462
Closed

Bug: Frames not using the button post_url #461

neekolas opened this issue Jul 25, 2024 · 0 comments · Fixed by #462
Assignees
@rygine
Labels
bug Something isn't working

Comments

@neekolas
Copy link
Contributor

Describe the bug

In the Open Frames standard, there is a hierarchy of which URL a button click should post to. If the button itself has a post_url defined that should be used instead of the frame-level post_url. It seems that our implementation isn't doing that.

Expected behavior

Button clicks should always URL as defined in the standard

Steps to reproduce the bug

No response
@neekolas neekolas added the bug Something isn't working label Jul 25, 2024
@rygine rygine self-assigned this Jul 26, 2024
@rygine rygine mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rygine rygine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support open frames button postUrl ephemeraHQ/xmtp-inbox-web
2 participants
@neekolas @rygine