Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support open frames button postUrl #462

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Support open frames button postUrl #462

merged 1 commit into from
Jul 26, 2024

Conversation

rygine
Copy link
Contributor

@rygine rygine commented Jul 26, 2024 •
edited
Loading

Summary

  • Upgraded @xmtp/frames-client and @open-frames/proxy-client
  • Refactored types
  • Allowed frames button postUrl to override frame postUrl

Resolves #461

@rygine rygine requested a review from a team July 26, 2024 18:30
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xmtp-inbox-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 6:34pm
xmtp-inbox-web-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 6:34pm

@rygine rygine merged commit 62b5917 into dev Jul 26, 2024
9 of 10 checks passed
@rygine rygine deleted the rygine/frames-button-post-url branch July 26, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Frames not using the button post_url
2 participants
@rygine @neekolas