Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue #572: Problem with BBCode and Markdown #573

Closed
NightScript370 opened this issue Mar 18, 2018 · 2 comments
Closed

Continue #572: Problem with BBCode and Markdown #573

NightScript370 opened this issue Mar 18, 2018 · 2 comments
Labels
Milestone

Comments

@NightScript370
Copy link

NightScript370 commented Mar 18, 2018

Yeah, I realised. Just that my board members love BBCode more than Markdown, but we like having markdown on the wiki.

Also, uh, another thing I've realised:

Posted by "DestroyerXL44" id="3297"

But the &-quot; thing replaces the " (sorry, github formatting)

I've tried ->setMarkupEscaped(false), but it didn't fix that.

I've also tried setSafeMode(true), but neither did that. fix it

For reference, below is my configuration:

	$text = Parsedown::instance()
		->setUrlsLinked(false)		# prevents automatic linking of URLs
		->setMarkupEscaped(false)
		->line($text);
@NightScript370
Copy link
Author

@aidantwoods I made a new issue, like you asked (in case you didn't notice)

@aidantwoods
Copy link
Collaborator

Thanks for reporting this @NightYoshi370.

Double quotes should always be permitted in the body of a HTML element that Parsedown produces – we only need to encode quotes when they go into an attribute (e.g. like when setting the alt description of an image). This to say that your example text should work regardless of escaping settings :)

There is a fix in #574. It ended up being a bit of a bigger change than I thought it would be initially, but encompassed some changes I was meaning to do anyway after #569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants