Remove legacy escaping #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2018
aidantwoods
force-pushed
the
fix/remove-legacy-escaping
branch
from
9bc0ca9
to
1fa6b03
Compare
|
No (actual) XSS issues found by Zap (one false-positive which is given below).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the newly added conditionally escaped HTML from #569 in combination with text-element adjacency from #511 to remove some special cased exceptions for HTML to circumvent the AST. In doing so we can get rid of the last of the old ways of escaping things.
Before merge I'm going to apply similar tests to those I did in #495 (i.e. a combination of manual testing and seeing if OWASP Zap can find any XSS with safe mode enabled).
cc: @PhrozenByte for review :)
Fixes #573