Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internet Archive Bookreader mobile menu is broken #262

Closed
aksm opened this issue Jan 18, 2023 · 3 comments
Closed

Internet Archive Bookreader mobile menu is broken #262

aksm opened this issue Jan 18, 2023 · 3 comments
Assignees
@aksm
Labels
bug Something isn't working

Comments

@aksm
Copy link
Contributor

aksm commented Jan 18, 2023

What?

When using the Internet Archive Bookreader the responsive hamburger menu isn't triggering as expected on appropriately sized windows.
@aksm aksm added the bug Something isn't working label Jan 18, 2023
@aksm aksm self-assigned this Jan 18, 2023
@aksm
Copy link
Contributor Author

aksm commented Jan 25, 2023

This took far longer than I expected to debug, but it turns out that we're missing the corresponding CSS for the following:

format_strawberryfield/format_strawberryfield.libraries.yml

Line 44 in 37c90b6

https://cdn.jsdelivr.net/npm/[email protected]/dist/jquery.mmenu.all.min.js: { external: true, minified: true, preprocess: false}

Will need our own additional CSS to match our theme. More to come.

@aksm aksm mentioned this issue Jan 25, 2023
Merged
@DiegoPino
Copy link
Member

wonderful! good catch!!

@aksm
Copy link
Contributor Author

aksm commented Feb 3, 2023

Resolved by #263 and #264.

@aksm aksm closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aksm aksm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DiegoPino @aksm