ISSUE-167: Style "share" pop-up window for IA Bookreader #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke everything funtion and look reasonable.
|
@DiegoPino will do some cross-browser testing on an archipelago-deployment-live (Facebook sharing doesn't work on localhost, though just switching to a public URL does) just to be sure, but glad to take any feedback at this stage if anything looks obviously problematic. |
|
Tested on latest Chrome, Safari, and Edge browsers on Linux, Mac, and Windows. |
DiegoPino
approved these changes
Feb 2, 2023
| shareBody.append(shareCheck, shareButtonContainer); | ||
| e.append(shareTitle, shareBody); | ||
| }; | ||
|
|
There was a problem hiding this comment.
wow this is a lot of code and JS ... do you think we could move a few of the "var" to "const" to help with memory here?
I'm trying to figure out performance lately and seems like our amount of JS is a bit over the roof. Just an idea. Need to test this before merging! Thanks a lot for your work on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167.
Phew, that was an unexpected journey. The Javascript and CSS are not ideal, but between clashing library themes, I did the best I could do. Needs some testing, particularly regarding the page/book URLs being generated and the various platform share URLs being generated/updated.