Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-106: Open API (OAI + any other) #202

Closed
wants to merge 17 commits into from
Closed

ISSUE-106: Open API (OAI + any other) #202

wants to merge 17 commits into from

Conversation

DiegoPino
Copy link
Member

See #106

This is not ready but safe to start pulling. It works, it caches, it uncaches, it replies. It does what it promises!
Requires

  • documentation
  • Templates that provide the per API logic (specially when dealing with Sword)
  • Better config form logic. Still does its thing but needs more conditionals, better validation, etc
  • Controller needs to be tested more.

Entity Form still requires some work and a few extra options, but a good start to test APIs. Documentation need to follow and this can not be merged until that is a reality.
@patdunlavey
Copy link
Collaborator

Hi @DiegoPino . I am (finally!) getting a chance to try to test this. I think I understand the basic idea of how this should work, but I'm kind of lost trying to set up my first example: OAI-ListSets. (I'm assuming I should create a separate end point for each OAI verb.) I bumbled my way around and created something, but of course it does nothing but say "No Content matches this Endpoint Enabled Bundles Configuration yet. Please create one to see a Demo link here."

A really basic ten minute brain dump of how to start using this from scratch would be extremely helpful, if you can find a moment for that!

Thanks friend!

@DiegoPino
Copy link
Member Author

DiegoPino commented Jun 14, 2022 via email

@DiegoPino
Copy link
Member Author

Ok, I tested this and it is not yet ready. The resumption token is not working as expected. (missed some code I did not push?) Will keep working tomorrow to make it release ready. Sorry folks!

Only if a path type argument is passed this is needed. So this fixes it
Silly me
For now this allows us to filter against mimetypes
Any autocomplete element using this handler can add
#selection_settings' => [
      'filter' => [
        'mimetype' => 'application/xml'
      ]
    ],
Going to attempt now (after this)
1.- better mapping for views exposed filters
2.- Multiple Views so mapping can be against one or another
3.- Multiple Twig templates, mapped to arguments
4.- Validation and cleanup
And better logic.
- Also fixes the case where two different arguments map to the same Views exposed property but on one is empty deleting the one that was set. If one is set and present that one wins
@DiegoPino DiegoPino changed the base branch from 1.0.0 to 1.1.0 August 24, 2022 00:57
…tons that trigger AJAX

I have repeated this to myself for the last 3 years and i always forget. I even have a sticky note
Given that Sets and Items have to be handled by different views we need to enable Multiple Views that can be modal based on enumeration properties.
I'm pretty sure i coded this for my birthday already but can't find it. Too many branches so here we go again
Might have to re-roll this later
@DiegoPino DiegoPino changed the base branch from 1.1.0 to 1.3.0 December 10, 2023 18:32
@DiegoPino
Copy link
Member Author

Closing in favor of #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants