ISSUE-106b:API builder/controller re-roll for 1.4.0 #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entity Form still requires some work and a few extra options, but a good start to test APIs. Documentation need to follow and this can not be merged until that is a reality.
Only if a path type argument is passed this is needed. So this fixes it
Silly me
For now this allows us to filter against mimetypes
Any autocomplete element using this handler can add
#selection_settings' => [
'filter' => [
'mimetype' => 'application/xml'
]
],
Going to attempt now (after this) 1.- better mapping for views exposed filters 2.- Multiple Views so mapping can be against one or another 3.- Multiple Twig templates, mapped to arguments 4.- Validation and cleanup
And better logic. - Also fixes the case where two different arguments map to the same Views exposed property but on one is empty deleting the one that was set. If one is set and present that one wins
…tons that trigger AJAX I have repeated this to myself for the last 3 years and i always forget. I even have a sticky note Given that Sets and Items have to be handled by different views we need to enable Multiple Views that can be modal based on enumeration properties. I'm pretty sure i coded this for my birthday already but can't find it. Too many branches so here we go again
Might have to re-roll this later
More to come, this is just glue so far
Also, actually save the entity. Gosh Diego
DiegoPino
added
enhancement
This was referenced Dec 26, 2023
DiegoPino
changed the title
…emplate Not that i have done that... but a todo is basically futuristic/wishful coding @alliomeria
What? @alliomeria well, drupal always gives me all with a min of 5 when using an entity reference view (which we need). This trick of first building it $executable->build(); // this will generate the query we need first, then setting the limit once all the non sense drupal did was already generated and override my pages allows me then to set a limit (and an offset which i can now calculate on a ?page or whatever argument) $executable->getQuery()->setLimit($limit); And then i can execute.. which was previously the default $executable->execute();
|
Thank you for baking this into Archipelago, @DiegoPino! 🌟 Local testing going great so far, and will stay tuned for the refinements we discussed earlier today. |
|
quizás, quizás we can close that ticket soon! Getting 4 years old anytime :) Thanks for testing and for the encouragement |
Still, need to think if we can use selective cache. We already have one for the items and we could allow just the wrapper to avoid caching?
YEs you can
This time this works well
|
@alliomeria do we need to provide an example/premade OAI stream for 1.4.0 (when release time comes)? How do we document this? Is April still Archipelago month for this/later? Are dandelions yellow? I don't know, I have seen white and pink ones. I feel it is ready for a beta test (merge) |
|
Sounds like a great plan to include an example/premade OAI stream for 1.4.0 @DiegoPino I think we can definitely reuse the local test templates we've been working with, and settings, can swap in the Archipelago Default DC + mods templates in place of the ones we customized for our partner too. Also happy to help document and all that good multicolored springtime jazz 🌼 🌸 💮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #106 but this time robust, well done (sorry, I was a mess in 2021) and fully functional
This can't be merged without me finishing the latest quirks (Cache clearing + invalidation + reusing existing metadata controller like IIIF Content Search API does) + better config form validation. Also we need to provide by default the configs + views + templates so this can be used out of the box by users.
Will keep adding things this week (Dec 18-24 2023)