ISSUE-304 --- Use the correct variable name for the aggregated fields #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$query_able_data gets iterated twice, the first time with its members called $query_able_datum_fields, and the second time as $query_able_datum_internal. During the second round of iterations ($query_able_datum_internal), the $query_able_datum_fields variable was referenced, which may or may not be the same as the current $query_able_datum_internal variable. When it is, no problem. But when it's not, the $query_able_datum_fields['aggregated'] may not be an array. The fix is to change out $query_able_datum_fields['aggregated'] for $query_able_datum_internal['aggregated']. For good measure, I added in extra validity checking for $query_able_datum_internal['aggregated'], though I don't think it's strictly necessary.
DiegoPino
added
bug
|
Thanks @patdunlavey for finding and fixing this! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$query_able_data gets iterated twice, the first time with its members called $query_able_datum_fields, and the second time as $query_able_datum_internal. During the second round of iterations ($query_able_datum_internal), the $query_able_datum_fields variable was referenced, which may or may not be the same as the current $query_able_datum_internal variable. When it is the same, no problem. But when it's not, the $query_able_datum_fields['aggregated'] may not be an array. This causes \Drupal\search_api_solr\Utility\Utility::flattenKeys to fatal error.
The fix is to change out $query_able_datum_fields['aggregated'] for $query_able_datum_internal['aggregated'].
For good measure, I added in extra validity checking for $query_able_datum_internal['aggregated'], though I don't think it's strictly necessary.
To test, create advanced searches using multiple filters, sbf aggregated fulltext and content fulltext, with at least one content fulltext filter following an sbf aggregated fulltext filter.