Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-304 --- Use the correct variable name for the aggregated fields #305

Merged
merged 1 commit into from
May 24, 2023
Merged

ISSUE-304 --- Use the correct variable name for the aggregated fields #305

merged 1 commit into from
May 24, 2023

Commits on May 24, 2023

  1. ISSUE-304 --- Use the correct variable name for the aggregated fields 

    $query_able_data gets iterated twice, the first time with its members called $query_able_datum_fields, and the second time as $query_able_datum_internal. During the second round of iterations ($query_able_datum_internal), the $query_able_datum_fields variable was referenced, which may or may not be the same as the current $query_able_datum_internal variable. When it is, no problem. But when it's not, the $query_able_datum_fields['aggregated'] may not be an array. 
The fix is to change out $query_able_datum_fields['aggregated'] for $query_able_datum_internal['aggregated'].
For good measure, I added in extra validity checking for $query_able_datum_internal['aggregated'], though I don't think it's strictly necessary.
    @patdunlavey
    patdunlavey authored May 24, 2023
    Configuration menu
    Copy the full SHA
    193da6a View commit details
    Browse the repository at this point in the history