ISSUE-442:Open API sanity + Controller cleanup #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are other trims somewhere ... need to check all of them
That way, even if the view returns nothing we can still return a response. Kind obvious @alliomeria but i am just so constantly tired lately i miss stuff
DiegoPino
added
bug
…elations to ... have a view be executed. That is obvious in my brain bc if we run a view always without any arguments, then the response would be always the same? also no limits? But better to be verbose @alliomeria
|
Merging for now. Of course we will find more issues bc this is complex science |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #442
More code to come @alliomeria