Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More sanity checks on Open API Builder #442

Closed
DiegoPino opened this issue Apr 22, 2024 · 2 comments
Closed

More sanity checks on Open API Builder #442

DiegoPino opened this issue Apr 22, 2024 · 2 comments
Assignees
@DiegoPino
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@DiegoPino
Copy link
Member

DiegoPino commented Apr 22, 2024 •
edited
Loading

What?

See #394 also

On live/production test @alliomeria detected a few issues with Form Validation (enumerations and UUID Entity validation) + Controller output (on empty we don't return a Response at all)

Will open a pull in a while to keep refining this new tool
@DiegoPino DiegoPino added the bug Something isn't working label Apr 22, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone Apr 22, 2024
@DiegoPino DiegoPino self-assigned this Apr 22, 2024
@alliomeria
Copy link
Contributor

Thank you @DiegoPino, for safely catching 🐛 and releasing 🦋.

I will keep testing and checking in production and let you know if I come across any other potential issues.

@DiegoPino DiegoPino mentioned this issue Apr 22, 2024
Merged
@DiegoPino
Copy link
Member Author

Resolved for now via 1d8963d
More code/issues will keep popping up. But fixes need to go in. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@DiegoPino @alliomeria