Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holocene-D: op-batcher: Add Holocene activation awareness #12122

Open
Tracked by #12120
sebastianst opened this issue Sep 25, 2024 · 2 comments
Open
Tracked by #12120

Holocene-D: op-batcher: Add Holocene activation awareness #12122

sebastianst opened this issue Sep 25, 2024 · 2 comments
Assignees

Comments

@sebastianst
Copy link
Member

sebastianst commented Sep 25, 2024

When Holocene activates, the derivation pipeline state will be mostly reset, per spec. So the batcher needs to be aware of this rule in the derivation pipeline, namely:
If the batcher has only partially submitted a channel pre-Holocene and then the L1 timestamp passes the Holocene activation timestamp, it has to submit the first frame(s) of the channel again, because they would be dropped in the frame queue/channel bank at Holocene activation.

@sebastianst sebastianst added this to the Holocene: Derivation milestone Sep 25, 2024
@sebastianst sebastianst changed the title Holocene-D: op-batcher: Add Holocene activation logic Holocene-D: op-batcher: Add Holocene activation awareness Sep 25, 2024
@geoknee
Copy link
Contributor

geoknee commented Oct 10, 2024

@sebastianst do you think if we implement #12124 it might just handle this case?

@geoknee
Copy link
Contributor

geoknee commented Oct 11, 2024

Answering my own question -- experimenting with #12430 I realise that that feature will have some inherent delay or lag (at least a few L1 block times). This might be too slow for Holocene activation (we know that situation is coming so we can probably respond to it quicker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants