batcher: batchSubmitter.checkExpectedProgress #12430
Draft
+48
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
changed the title
|
Semgrep found 1 TODO in error handling code Ignore this finding from err-todo. |
geoknee
commented
Oct 11, 2024
| // Set to 1 to allow e.g. 12s for the safe head to advance | ||
| // after the L1 inclusion block was ingested. | ||
| // TODO extract this into a config variable | ||
| // TODO should we also wait numConfirmations (this is a txmgr config variable, not in scope of the batch submitter) |
There was a problem hiding this comment.
What we really want to know is the verifier numConfirmations, but I don't think we can get access to that. We probably have to proceed with our own conservative buffer / confirmation depth.
When this is a CLI config variable, it can be set in a coordinated way with how the verifier node / sequencer is configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #12124