feat: Replace deployImplementations with call to DeployImplementations.run() #12260
+178
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maurelian and the rest of your teammates on |
maurelian
changed the title
Merge activity
|
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
5b4da04
to
2426d15
Compare
|
Semgrep found 2 require() must include a reason string Ignore this finding from sol-style-require-reason. |
|
Semgrep found 138
require() must include a reason string Ignore this finding from sol-style-require-reason. |
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
434e651
to
1430998
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
1430998
to
8f88513
Compare
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
8f88513
to
2d47ce4
Compare
maurelian
commented
Oct 3, 2024
maurelian
commented
Oct 3, 2024
maurelian
commented
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
7a16f1d
to
447a292
Compare
Preimage Oracle DelayedWeth DGF A ChainAssertion was also added for the PreimageOracle
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
8c294f8
to
3206858
Compare
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
…s.run() (#12260) * feat: Rename setupSuperchain to deploySuperchain * feat: Replace deployImplementations with call to DeployImplementations.run() * feat: Add implsUnstrict() to get all impl addresses * feat: Remove deployL1xDM and move its ChainAssertion to deployImplementations * feat: Remove deployOptimismPortal2 and move its assertion to deplyImpls * feat: Remove deployOptimismMintableFactory and move its assertion to deplyImpl * fix: test file name * fix: Incorrect implementation contract name in _implUnstrict() * feat: Add checkSystemConfigInterop * feat: Move unused deploySuperchainConfig to DeployOwnership * feat: Delete deployOptimismPortalInterop * feat: Delete unused FP deploy functions Preimage Oracle DelayedWeth DGF A ChainAssertion was also added for the PreimageOracle * feat: Delete deploySystemConfig * feat: remove superfluous Unstrict suffix from contract getters * feat: Improve reason string in checkSystemConfigI * feat: Add missing chainAssertions * feat: Require interop flag sanity * feat: limit fuzz runs in CI on this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Rename setupSuperchain to deploySuperchain
feat: Replace deployImplementations with call to DeployImplementations.run()