Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete FPACOPs and unused deploy functions #12261

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

maurelian
Copy link
Contributor

feat: delete unused deploy functions

feat: Annotate functions used in FPACOPS scripts

Copy link
Contributor Author

maurelian commented Oct 2, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maurelian and the rest of your teammates on Graphite Graphite

@maurelian maurelian force-pushed the opcm/tests/delete-unused-funcs branch from 8dc9a90 to edb5941 Compare October 2, 2024 19:11
@maurelian maurelian marked this pull request as ready for review October 2, 2024 19:11
@maurelian maurelian requested a review from a team as a code owner October 2, 2024 19:11
@maurelian maurelian requested review from clabby and removed request for a team October 2, 2024 19:11
@maurelian maurelian changed the title feat: delete unused deploy functions feat: delete FPACOPs and unused deploy functions Oct 2, 2024
@maurelian maurelian changed the title feat: delete FPACOPs and unused deploy functions feat: delete FPACOPs and unused deploy functions Oct 2, 2024
@maurelian maurelian requested review from smartcontracts and removed request for clabby October 2, 2024 19:12
@maurelian maurelian force-pushed the opcm/tests/delete-unused-funcs branch from edb5941 to d23d2bd Compare October 2, 2024 19:16
Copy link
Contributor

semgrep-app bot commented Oct 2, 2024

Semgrep found 2 sol-style-require-reason findings:

require() must include a reason string

Ignore this finding from sol-style-require-reason.

@tynes tynes merged commit 434e651 into opcm/tests/deploy-impls Oct 3, 2024
55 of 56 checks passed
@tynes tynes deleted the opcm/tests/delete-unused-funcs branch October 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants