Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump web3.js to v1.7.5 #543

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Bump web3.js to v1.7.5 #543

merged 2 commits into from
Sep 23, 2022

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Aug 24, 2022

To fix the recent Brave browser issue, this PR bumps web3.js package version to v1.7.5.

TODO:

  • Test deposit function

@hwwhww hwwhww marked this pull request as ready for review August 24, 2022 08:24
@hwwhww
Copy link
Contributor Author

hwwhww commented Aug 24, 2022

Hey @samajammin @wackerow
This PR works for me locally. But somehow Netlify didn't install successfully.

Newbie question: I clicked the "Re-run" button of one failed check and then saw "You have successfully requested Header rules - serene-carson-3331d5 be rerun":
image

But I couldn't find the re-run job. Any idea of how to resolve it?

@wackerow
Copy link
Member

@hwwhww This appears to be a Node JS version issue...

1:18:32 AM: error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14.16". Got "10.24.1"
1:18:32 AM: error Found incompatible module.

We appear to be using 10.24.1 (lts/dubnium) while this is requiring >=14.16 (lts/fermium).

@CarlBeek Have we looked into updating the node version in the past? Any idea if that would affect anything else on the site? I generally use lts/gallium -> v16.17.0 as my default, and locally the site has always worked, and this PR also works fine if using that version, but breaks as soon as I switch to 10.24.1

@CarlBeek
Copy link
Contributor

In general, updating the packages would be good. I made an attempt in the past to update everything to the latest stable versions and then lost a day to dependency hell trying to figure out what was and wasn't working. That said, this is probably more a fault of my JS skills than anything else.

@hwwhww
Copy link
Contributor Author

hwwhww commented Sep 2, 2022

@wackerow I rebased this PR with #546 changes, it works now! 🎉

@meshin-dev
Copy link

Guys please merge it as soon as possible

@meshin-dev
Copy link

What is the status of this?

@wackerow wackerow merged commit c2daff1 into dev Sep 23, 2022
This was referenced Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants