Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create netlify.toml, update node version #546

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Create netlify.toml, update node version #546

merged 3 commits into from
Sep 2, 2022

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Aug 24, 2022

  • Creates netlify.toml (git tracked)
  • Initializes with production, deploy-preview, branch-deploy and dev context to add NODE_VERSION environment var
  • Set node version to 16.15.0, currently latest stable release
  • Set node version to 14.19.2* (currently using 10.24.1

* Attempted to use v16 and the build failed. We could look into this separately, but v14 is working which is what is required for #543 to pass.

image

@wackerow wackerow marked this pull request as draft August 24, 2022 19:58
@wackerow
Copy link
Member Author

According to the build logs this didn't seem to have an impact on the node version being used. Marking as draft for now and will have to circle back

@wackerow wackerow marked this pull request as ready for review September 2, 2022 01:33
@hwwhww hwwhww merged commit 5a85186 into dev Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants