Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP140: REVERT #232

Closed
pirapira opened this issue Feb 13, 2017 · 5 comments · Fixed by #411
Closed

EIP140: REVERT #232

pirapira opened this issue Feb 13, 2017 · 5 comments · Fixed by #411
Assignees
@pirapira

Comments

@pirapira
Copy link
Member

pirapira commented Feb 13, 2017 •
edited
Loading

This issue keeps track of adoption of ethereum/EIPs#206 and https:/ethereum/EIPs/pull/207/files, which introduce the REVERT instruction.

EDIT: ethereum/EIPs#207 is not about protocol consensus anyway, so not relevant for the Yellow Paper.
@pirapira pirapira mentioned this issue Feb 13, 2017
Closed
12 tasks
@pirapira
Copy link
Member Author

pirapira commented Feb 20, 2017 •
edited
Loading

  • The sentence "no instruction can, through its instruction, cause an exceptional halt" needs to be changed.

@pirapira pirapira self-assigned this Feb 20, 2017
@pirapira
Copy link
Member Author

pirapira commented Feb 20, 2017 •
edited
Loading

  • \Xi and \Lambda needs to return gas after REVERT.

@pirapira pirapira mentioned this issue Feb 20, 2017
Open
@pirapira
Copy link
Member Author

#238 and #239 needs to be fixed first. Otherwise, the gas-returning nature of REVERT cannot be expressed.

@pirapira pirapira mentioned this issue Feb 20, 2017
Merged
pirapira added a commit to pirapira/yellowpaper that referenced this issue Feb 21, 2017
@pirapira
Define REVERT instruction
5473d52 
Fixes ethereum#232
pirapira added a commit to pirapira/yellowpaper that referenced this issue Feb 21, 2017
@pirapira
Define REVERT instruction
b7a939a 
Fixes ethereum#232
pirapira added a commit to pirapira/yellowpaper that referenced this issue Feb 21, 2017
@pirapira
Define REVERT instruction
619ef8d 
Fixes ethereum#232
pirapira added a commit to pirapira/yellowpaper that referenced this issue Feb 21, 2017
@pirapira
Define REVERT instruction
360c00e 
Fixes ethereum#232
pirapira added a commit to pirapira/yellowpaper that referenced this issue Feb 21, 2017
@pirapira
Define REVERT instruction
a2209cd 
Fixes ethereum#232
@pirapira pirapira mentioned this issue Feb 21, 2017
Closed
@msuiche
Copy link

msuiche commented Feb 24, 2017

@pirapira Can we expect the REVERT instruction to be appended to the yellowpaper ?

If not it would be misleading to not have every instruction documented by the yellowpaper, especially when they can be found in the instruction list of the source code of Solidity:
https:/ethereum/solidity/blob/develop/libevmasm/Instruction.cpp#L162

Or is it because it hasn't been merge to release branch yet ?

@pirapira
Copy link
Member Author

@msuiche there is a pull-request #242 about that.

pirapira added a commit to pirapira/yellowpaper that referenced this issue Feb 24, 2017
@pirapira
Define REVERT instruction
45f691c 
Fixes ethereum#232
@pirapira pirapira mentioned this issue Mar 29, 2017
Closed
This was referenced May 10, 2017
Closed
Closed
@pirapira pirapira mentioned this issue Jan 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirapira pirapira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Byzantium: EIP140 REVERT pirapira/yellowpaper
2 participants
@pirapira @msuiche