Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metropolis: EIP140 REVERT #278

Closed
wants to merge 4 commits into from
Closed

Metropolis: EIP140 REVERT #278

wants to merge 4 commits into from

Conversation

pirapira
Copy link
Member

@pirapira pirapira commented Mar 29, 2017 •
edited
Loading

As part of the Metropolis changes #229, this PR specifies REVERT instruction.

This fixes #232.

This makes more sense after #263 and #265.

@pirapira
\Xi does not return output on exceptional halt
c51b0cf 
This makes the exceptional halts easier to distinguish from reverts
@pirapira
Specify REVERT
2fd0b70 
Following https:/ethereum/EIPs/pull/206/files
@pirapira pirapira changed the title Specify REVERT EIP 140: REVERT Mar 29, 2017
@pirapira pirapira mentioned this pull request Mar 29, 2017
Closed
12 tasks
@pirapira pirapira changed the title EIP 140: REVERT Metropolis: EIP140 REVERT Apr 28, 2017
@pirapira pirapira mentioned this pull request May 9, 2017
Closed
@pirapira
Copy link
Member Author

pirapira commented May 10, 2017 •
edited
Loading

  • The contract creating function \Lambda should now return a data output when the execution finishes with REVERT.

@pirapira pirapira changed the title Metropolis: EIP140 REVERT [WIP] Metropolis: EIP140 REVERT May 10, 2017
@pirapira
EIP 140: the output from REVERT during a contract creation
7bbf1d5 
should be accessible from RETURNDATASIZE and RETURNDATACOPY, so \Lambda should return four values.
@pirapira pirapira changed the title [WIP] Metropolis: EIP140 REVERT Metropolis: EIP140 REVERT May 10, 2017
@pirapira
Copy link
Member Author

This PR should now target master because now master is the Byzantium branch.

@pirapira pirapira closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pirapira