This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
tests(rpc): add filter tests #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danburck
changed the title
fedekunze
approved these changes
Aug 12, 2022
|
@facs95 @ramacarlucho @yihuang seems like the test_get_proof is failing even though this PR doesn't touch the types. The last two merged commits passed: Any idea why it's failing? |
yihuang
reviewed
Aug 12, 2022
Have no idea right now, didn't reproduce locally, maybe you try rerun, it'll success 🤔 |
|
I think the priority test failure is due to the dropping of the base fee, which causes the actual tx priority not as expected when sent, I'll update some numbers to make the drop effect less significant. |
|
|
facs95
approved these changes
Aug 12, 2022
yihuang
approved these changes
Aug 12, 2022
facs95
pushed a commit
that referenced
this pull request
Aug 12, 2022
* tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]>
fedekunze
added a commit
that referenced
this pull request
Aug 13, 2022
* changelog * Add support for miner_setGasPrice API (#1237) * fix kv indexer unit test * fix(rpc): get_proof test fail because block numbers are not high enough (#1239) * Problem: get_proof test fail because block numbers are not high enough Solution: - wait for app block height rather than tendermint block height * Update tests/integration_tests/test_types.py * keep get_proof response the same as geth Co-authored-by: Daniel Burckhardt <[email protected]> * tests(rpc): add filter tests (#1233) * tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]> * changelog * update gomod2nix * fix python linter * Apply suggestions from code review * Update CHANGELOG.md Co-authored-by: yihuang <[email protected]> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Aug 17, 2022
* changelog * Add support for miner_setGasPrice API (evmos#1237) * fix kv indexer unit test * fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239) * Problem: get_proof test fail because block numbers are not high enough Solution: - wait for app block height rather than tendermint block height * Update tests/integration_tests/test_types.py * keep get_proof response the same as geth Co-authored-by: Daniel Burckhardt <[email protected]> * tests(rpc): add filter tests (evmos#1233) * tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]> * changelog * update gomod2nix * fix python linter * Apply suggestions from code review * Update CHANGELOG.md Co-authored-by: yihuang <[email protected]> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain
pushed a commit
to PundiAI/ethermint
that referenced
this pull request
Nov 17, 2022
* changelog * Add support for miner_setGasPrice API (evmos#1237) * fix kv indexer unit test * fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239) * Problem: get_proof test fail because block numbers are not high enough Solution: - wait for app block height rather than tendermint block height * Update tests/integration_tests/test_types.py * keep get_proof response the same as geth Co-authored-by: Daniel Burckhardt <[email protected]> * tests(rpc): add filter tests (evmos#1233) * tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]> * changelog * update gomod2nix * fix python linter * Apply suggestions from code review * Update CHANGELOG.md Co-authored-by: yihuang <[email protected]> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 3762738)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds basic integration tests for testing JSON RPC eth filters on a ethermint/geth cluster. In the future we should add more complex testing cases.
Closes https://linear.app/evmos/issue/ENG-642/integration-test-json-rpc-filters