Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: priority test result affect by base fee dropping #1238

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 12, 2022

Description

Solution:

  • increase the scale of priority numbers to make it more stable.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- increase the scale of priority numbers to make it more stable.
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @yihuang, can you fix the linter?

@yihuang
Copy link
Contributor Author

yihuang commented Aug 12, 2022

LGTM @yihuang, can you fix the linter?

done

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze enabled auto-merge (squash) August 12, 2022 15:39
@fedekunze fedekunze merged commit d596594 into evmos:main Aug 12, 2022
@yihuang yihuang deleted the fix-test-stable branch August 12, 2022 18:02
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants