-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: rescale logarithmic network graph to show 1 kB/s closer to y-axis #2088
Comments
Fixing this might be as simple as changing the multiplier factor here from 100 to 1 or similar: stats/Kit/plugins/Charts.swift Lines 47 to 53 in 5649f24
|
corneliusroemer
added a commit
to corneliusroemer/stats
that referenced
this issue
Aug 25, 2024
Resolves exelban#2088 Previously, dynamic range of log scale was bad because 0.01 Bytes/second (10e-2) was mapped to 0 Commonly found values for network speed range from 1kB/second (10e3) to 100GB/second (10e8) As a result, half of the dynamic range was wasted as no values would ever appear between 10e-2 and 10e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I love that you have logarithmic scaling for the network graph. That's a great touch!
One suggestion: right now, there's unfortunately relatively little dynamic range because the y-value for 1kB/s is already relative large:
It would be great if you changed the graph log y-scale so that 1kB/s was closer to the 0-value of the y-axis. This would easily double the dynamic scale.
You might feel like this is a hack - but it isn't! You always have to arbitrarily choose where to put the minimum value on a log scale that doesn't go all the way to 0. Right now, the y-axis is maybe at around 1B/s which is never actually measured. The minimum that can be resolved is 1kB/s in my experience, so that's what should be close to 0 (not exactly 0 because we want to be able to tell 1kB/s apart from 0kB/s).
Does my suggestion make sense? I'm happy to explain further if it's not clear.
The text was updated successfully, but these errors were encountered: