fix: make log scale graph have better dynamic range #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
force-pushed
the
fix-log-scale
branch
from
679ddf7
to
d739049
Compare
exelban
reviewed
Aug 25, 2024
corneliusroemer
commented
Aug 25, 2024
corneliusroemer
commented
Aug 25, 2024
Signed-off-by: Cornelius Roemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2088
Previously, dynamic range of log scale was bad because 0.01 Bytes/second (10e-2) was mapped to 0
Commonly found values for network speed range from 1kB/second (10e3) to 100GB/second (10e8)
As a result, half of the dynamic range was wasted as no values would ever appear between 10e-2 and 10e3.
New:
Before: