Fix activation lookup with Python 3.12.3 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the metaclass `EnumMeta`/`EnumType` to override reporting of missing enum values (to give the full set of supported activations). However, in Python 3.12.3, the default value of the `name` parameter of `EnumType.__call__` method was changed from `None` to `_not_given`: python/cpython@d771729 Even though this is a public API (which now uses a private default value), it seems too risky to continue using it. So in this change, we implement `Enum.__mising__` instead for the improved error reporting.
3 tasks
svlandeg
approved these changes
Apr 17, 2024
svlandeg
reviewed
Apr 17, 2024
Not yet, but it sounds good to have this. I'll do a PR for that after getting new releases for 2.0.x and 1.3.x out. |
danieldk
added a commit
to danieldk/curated-transformers
that referenced
this pull request
Apr 17, 2024
We used the metaclass `EnumMeta`/`EnumType` to override reporting of missing enum values (to give the full set of supported activations). However, in Python 3.12.3, the default value of the `name` parameter of `EnumType.__call__` method was changed from `None` to `_not_given`: python/cpython@d771729 Even though this is a public API (which now uses a private default value), it seems too risky to continue using it. So in this change, we implement `Enum.__mising__` instead for the improved error reporting.
danieldk
added a commit
that referenced
this pull request
Apr 17, 2024
* Fix activation lookup with Python 3.12.3 (#375) We used the metaclass `EnumMeta`/`EnumType` to override reporting of missing enum values (to give the full set of supported activations). However, in Python 3.12.3, the default value of the `name` parameter of `EnumType.__call__` method was changed from `None` to `_not_given`: python/cpython@d771729 Even though this is a public API (which now uses a private default value), it seems too risky to continue using it. So in this change, we implement `Enum.__mising__` instead for the improved error reporting. * Set version to 1.3.2 * Adjust two cross-tests for changes in HF transformers (#367) * Fix `test_rotary_embeddings_against_hf` for latest transformers * xfail test because HfFileSystem is currently broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used the metaclass
EnumMeta/EnumTypeto override reporting of missing enum values (to give the full set of supported activations). However, in Python 3.12.3, the default value of thenameparameter ofEnumType.__call__method was changed fromNoneto_not_given:python/cpython@d771729
Even though this is a public API (which now uses a private default value), it seems too risky to continue using it. So in this change, we implement
Enum.__mising__instead for the improved error reporting.Checklist