Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Curated Transformers 2.0 API changes #37

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Update for Curated Transformers 2.0 API changes #37

merged 1 commit into from
Apr 18, 2024

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Apr 16, 2024 •
edited
Loading

Description

Account for renaming of FromHFHub to FromHF.

Types of change

Maintenance.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk requested review from shadeMe and removed request for shadeMe April 16, 2024 13:21
@danieldk
Copy link
Contributor Author

Test fails due to Python 3.12.3 breakage, fix needs to be rolled out in Curated Transformers first: explosion/curated-transformers#375

shadeMe
shadeMe approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after the tests pass.

@danieldk danieldk merged commit 184f447 into explosion:v4 Apr 18, 2024
6 of 8 checks passed
@danieldk danieldk deleted the maintenance/curated-2.0-api-changes branch April 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieldk @shadeMe