Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫 Fix bugs in matcher extensions. Closes #1971 #3301

Merged
merged 3 commits into from
Feb 20, 2019
Merged

💫 Fix bugs in matcher extensions. Closes #1971 #3301

merged 3 commits into from
Feb 20, 2019

Conversation

honnibal
Copy link
Member

  • Fix detection of match_id when using extension attributes. The match
    ID is stored as the last entry in the pattern. We were checking for this
    with nr_attr == 0, which didn't account for extension attributes.

  • Fix handling of predicates. The wrong count was being passed through,
    so even patterns that didn't have a predicate were being checked.

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@honnibal
Fix matching on extension attrs and predicates
a198813 
* Fix detection of match_id when using extension attributes. The match
ID is stored as the last entry in the pattern. We were checking for this
with nr_attr == 0, which didn't account for extension attributes.

* Fix handling of predicates. The wrong count was being passed through,
so even patterns that didn't have a predicate were being checked.
@honnibal
Fix regex pattern
06d79f2
@honnibal honnibal requested a review from ines February 20, 2019 16:54
@ines ines changed the title Fix bugs in matcher extensions. Closes #1972 💫 Fix bugs in matcher extensions. Closes #1972 Feb 20, 2019
@ines ines added bug Bugs and behaviour differing from documentation 🌙 nightly Discussion and contributions related to nightly builds feat / matcher Feature: Token, phrase and dependency matcher labels Feb 20, 2019
@ines ines changed the title 💫 Fix bugs in matcher extensions. Closes #1972 💫 Fix bugs in matcher extensions. Closes #1971 Feb 20, 2019
@ines ines merged commit 0d1ca15 into develop Feb 20, 2019
@ines ines deleted the bugfix/matcher-extensions branch February 20, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ines ines Awaiting requested review from ines

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / matcher Feature: Token, phrase and dependency matcher 🌙 nightly Discussion and contributions related to nightly builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honnibal @ines