Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫 Fix bugs in matcher extensions. Closes #1971 #3301

Merged
merged 3 commits into from
Feb 20, 2019
Merged

💫 Fix bugs in matcher extensions. Closes #1971 #3301

merged 3 commits into from
Feb 20, 2019

Commits on Feb 20, 2019

  1. Fix matching on extension attrs and predicates 

    * Fix detection of match_id when using extension attributes. The match
ID is stored as the last entry in the pattern. We were checking for this
with nr_attr == 0, which didn't account for extension attributes.

* Fix handling of predicates. The wrong count was being passed through,
so even patterns that didn't have a predicate were being checked.
    @honnibal
    honnibal committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    a198813 View commit details
    Browse the repository at this point in the history

  2. Fix regex pattern

    @honnibal
    honnibal committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    06d79f2 View commit details
    Browse the repository at this point in the history

  3. Fix matcher set value test

    @honnibal
    honnibal committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    09f2189 View commit details
    Browse the repository at this point in the history