Use already extracted values instead of reading off props for control…

…led components (#26596) Since `props.x` is a possibly megamorphic access, it can be slow to access and trigger recompilation. When we are looping over the props and pattern matching every key, anyway, we've already done this work. We can just reuse the same value by stashing it outside the loop in the stack. This only makes sense for updates in diffInCommitPhase since otherwise we don't have the full set of props in that loop. We also have to be careful not to skip over equal values since we need to extract them anyway. DiffTrain build for commit 6b90976.
facebook · Apr 11, 2023 · 95cf715 · 95cf715
1 parent 32f13ee
commit 95cf715
Show file tree

Hide file tree

Showing 13 changed files with 19 additions and 19 deletions.
diff --git a/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js b/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
@@ -23752,7 +23752,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-next-343a45ffa-20230411";
+var ReactVersion = "18.3.0-next-6b90976bc-20230411";
 
 // Might add PROFILE later.
 

diff --git a/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js b/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
@@ -8610,7 +8610,7 @@ var devToolsConfig$jscomp$inline_1021 = {
  throw Error("TestRenderer does not support findFiberByHostInstance()");
  },
  bundleType: 0,
- version: "18.3.0-next-343a45ffa-20230411",
+ version: "18.3.0-next-6b90976bc-20230411",
  rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1204 = {
@@ -8641,7 +8641,7 @@ var internals$jscomp$inline_1204 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
+ reconcilerVersion: "18.3.0-next-6b90976bc-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1205 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
@@ -9036,7 +9036,7 @@ var devToolsConfig$jscomp$inline_1063 = {
  throw Error("TestRenderer does not support findFiberByHostInstance()");
  },
  bundleType: 0,
- version: "18.3.0-next-343a45ffa-20230411",
+ version: "18.3.0-next-6b90976bc-20230411",
  rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1245 = {
@@ -9067,7 +9067,7 @@ var internals$jscomp$inline_1245 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
+ reconcilerVersion: "18.3.0-next-6b90976bc-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1246 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js
@@ -27,7 +27,7 @@ if (
 }
  "use strict";
 
-var ReactVersion = "18.3.0-next-343a45ffa-20230411";
+var ReactVersion = "18.3.0-next-6b90976bc-20230411";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-next-343a45ffa-20230411";
+exports.version = "18.3.0-next-6b90976bc-20230411";
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
  );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-next-343a45ffa-20230411";
+exports.version = "18.3.0-next-6b90976bc-20230411";
 
  /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
@@ -1 +1 @@
-343a45ffa48065e60699bbe68f82d7b62fa02840
+6b90976bc10f325146b193286435a4b5015ef605
diff --git a/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
@@ -27059,7 +27059,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-next-343a45ffa-20230411";
+var ReactVersion = "18.3.0-next-6b90976bc-20230411";
 
 function createPortal$1(
  children,

diff --git a/...ce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js b/...ce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
@@ -9479,7 +9479,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1045 = {
  findFiberByHostInstance: getInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-next-343a45ffa-20230411",
+ version: "18.3.0-next-6b90976bc-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -9521,7 +9521,7 @@ var internals$jscomp$inline_1274 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
+ reconcilerVersion: "18.3.0-next-6b90976bc-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1275 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...lat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js b/...lat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
@@ -10188,7 +10188,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1123 = {
  findFiberByHostInstance: getInstanceFromNode,
  bundleType: 0,
- version: "18.3.0-next-343a45ffa-20230411",
+ version: "18.3.0-next-6b90976bc-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -10243,7 +10243,7 @@ var roots = new Map(),
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
+ reconcilerVersion: "18.3.0-next-6b90976bc-20230411"
 });
 exports.createPortal = function (children, containerTag) {
  return createPortal$1(

diff --git a/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
@@ -27572,7 +27572,7 @@ function createFiberRoot(
  return root;
 }
 
-var ReactVersion = "18.3.0-next-343a45ffa-20230411";
+var ReactVersion = "18.3.0-next-6b90976bc-20230411";
 
 function createPortal$1(
  children,

diff --git a/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
@@ -9738,7 +9738,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1100 = {
  findFiberByHostInstance: getInstanceFromTag,
  bundleType: 0,
- version: "18.3.0-next-343a45ffa-20230411",
+ version: "18.3.0-next-6b90976bc-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -9780,7 +9780,7 @@ var internals$jscomp$inline_1343 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
+ reconcilerVersion: "18.3.0-next-6b90976bc-20230411"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1344 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
@@ -10447,7 +10447,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1178 = {
  findFiberByHostInstance: getInstanceFromTag,
  bundleType: 0,
- version: "18.3.0-next-343a45ffa-20230411",
+ version: "18.3.0-next-6b90976bc-20230411",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForViewTag: function () {
@@ -10502,7 +10502,7 @@ var roots = new Map(),
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "18.3.0-next-343a45ffa-20230411"
+ reconcilerVersion: "18.3.0-next-6b90976bc-20230411"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
  computeComponentStackForErrorReporting: function (reactTag) {