Move flags to experimental #28151
Closed
Move flags to experimental #28151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Jan 29, 2024
| @@ -1057,70 +1057,69 @@ describe('ReactComponentLifeCycle', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| if (!require('shared/ReactFeatureFlags').disableModulePatternComponents) { | |||
There was a problem hiding this comment.
These tests were implicitly depending on the fact that disableModulePatternComponents and disableLegacyContext always had the same value, so now we need to provide both.
rickhanlonii
commented
Feb 7, 2024
| @@ -799,8 +799,7 @@ describe('ReactErrorBoundaries', () => { | |||
| expect(container.firstChild.textContent).toBe('Caught an error: Hello.'); | |||
| }); | |||
|
|
|||
| // @gate !disableModulePatternComponents | |||
| // @gate !disableLegacyContext | |||
| // @gate !(disableModulePatternComponents && disableLegacyContext) | |||
There was a problem hiding this comment.
Should be an or not and, and i deMorgan'd it to make it clearer
rickhanlonii
force-pushed
the
rh/legacy-context
branch
from
eca203a
to
5405fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.