Hash local package name #2600
Merged
Hash local package name #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
approved these changes
Jun 29, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| ## dbt 0.17.1 (Release TBD) | |||
|
|
|||
| ### Fixes | |||
| - Hash name of local packages | |||
There was a problem hiding this comment.
Please link to this PR as well, otherwise lgtm
There was a problem hiding this comment.
ha, but how does one know the PR number before creating the PR 🤔
There was a problem hiding this comment.
Two ways: I look at the highest existing PR/issue numbers and add 1, and then if someone opens one in the interim I fix it with a git commit --amend; git push -f. Alternatively, I open it as a draft, copy the issue number in to the changelog, and do the git commit --amend; git push -f before I ask for reviews. Both suck!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Description
Ensure we hash local package names — this was a regression introduced in #2429
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.