-
Notifications
You must be signed in to change notification settings - Fork 206
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: don't allow to delete segment which is in use (#3552)
- Loading branch information
Showing
10 changed files
with
218 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ALTER TABLE rule_segments DROP CONSTRAINT fk_namespace_key_ref_segments; | ||
| ALTER TABLE rule_segments ADD CONSTRAINT fk_namespace_key_ref_segments FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, key) ON DELETE RESTRICT; | ||
|
|
||
| ALTER TABLE rollout_segment_references DROP CONSTRAINT fk_namespace_key_ref_segments; | ||
| ALTER TABLE rollout_segment_references | ||
| ADD CONSTRAINT fk_namespace_key_ref_segments FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, key) ON DELETE RESTRICT; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ALTER TABLE rule_segments DROP FOREIGN KEY `rule_segments_ibfk_2`; | ||
| ALTER TABLE rule_segments ADD CONSTRAINT `rule_segments_ibfk_2` FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, `key`) ON DELETE RESTRICT; | ||
|
|
||
| ALTER TABLE rollout_segment_references DROP FOREIGN KEY `rollout_segment_references_ibfk_2`; | ||
| ALTER TABLE rollout_segment_references | ||
| ADD CONSTRAINT `rollout_segment_references_ibfk_2` FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, `key`) ON DELETE RESTRICT; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ALTER TABLE rule_segments DROP CONSTRAINT rule_segments_namespace_key_segment_key_fkey; | ||
| ALTER TABLE rule_segments ADD CONSTRAINT rule_segments_namespace_key_segment_key_fkey FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, key) ON DELETE RESTRICT; | ||
|
|
||
| ALTER TABLE rollout_segment_references DROP CONSTRAINT rollout_segment_references_namespace_key_segment_key_fkey; | ||
| ALTER TABLE rollout_segment_references | ||
| ADD CONSTRAINT rollout_segment_references_namespace_key_segment_key_fkey FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, key) ON DELETE RESTRICT; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| -- rule_segments | ||
| CREATE TABLE rule_segments_temp ( | ||
| rule_id VARCHAR(255) NOT NULL REFERENCES rules ON DELETE CASCADE, | ||
| namespace_key VARCHAR(255) NOT NULL, | ||
| segment_key VARCHAR(255) NOT NULL, | ||
| UNIQUE (rule_id, namespace_key, segment_key), | ||
| FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, key) ON DELETE RESTRICT | ||
| ); | ||
|
|
||
| INSERT INTO rule_segments_temp (rule_id, namespace_key, segment_key) SELECT rule_id, namespace_key, segment_key FROM rule_segments; | ||
| DROP TABLE rule_segments; | ||
| ALTER TABLE rule_segments_temp RENAME TO rule_segments; | ||
|
|
||
| -- rollout_segment_references | ||
| CREATE TABLE rollout_segment_references_temp ( | ||
| rollout_segment_id VARCHAR(255) NOT NULL REFERENCES rollout_segments ON DELETE CASCADE, | ||
| namespace_key VARCHAR(255) NOT NULL, | ||
| segment_key VARCHAR(255) NOT NULL, | ||
| UNIQUE (rollout_segment_id, namespace_key, segment_key), | ||
| FOREIGN KEY (namespace_key, segment_key) REFERENCES segments (namespace_key, key) ON DELETE RESTRICT | ||
| ); | ||
|
|
||
| INSERT INTO rollout_segment_references_temp (rollout_segment_id, namespace_key, segment_key) SELECT rollout_segment_id, namespace_key, segment_key FROM rollout_segment_references; | ||
| DROP TABLE rollout_segment_references; | ||
| ALTER TABLE rollout_segment_references_temp RENAME TO rollout_segment_references; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.