Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLI-708] Warn user when trying to delete a segment this is in use #2403

Closed
1 task done
phenax opened this issue Nov 16, 2023 · 2 comments · Fixed by #3552
Closed
1 task done

[FLI-708] Warn user when trying to delete a segment this is in use #2403

phenax opened this issue Nov 16, 2023 · 2 comments · Fixed by #3552
Labels

Comments

@phenax
Copy link
Contributor

phenax commented Nov 16, 2023

Problem

There is no indication to the user trying to delete a segment how the operation will affect the flags.

Ideal Solution

A message in the delete modal that highlights for the user that the segment being deleted is currently in use.

Something like "This flag is currently being used in 3 flags"

Search

  • I searched for other open and closed issues before opening this

Additional Context

No response

FLI-708

@GeorgeMac
Copy link
Contributor

Very reasonable.

I think (since we addressed some feedback) that with the declarative backends you now get an error when validating your config when this referential constraint is violated. So this should only effect the relational backends. Just noting for the future given we implement fixing this.

@markphelps markphelps added the ui label Nov 16, 2023
@markphelps
Copy link
Collaborator

We plan to move segments to use Redux, much like @GeorgeMac did in #2301. I think doing that for segments and rules/rollouts might make fixing this much easier, as we could then cross reference each segment with flags/rules/rollouts at deletion time to do the check.

will create issues for moving these resources to redux incase anyone is able to help there

@markphelps markphelps changed the title Warn user when trying to delete a segment this is in use [FLI-708] Warn user when trying to delete a segment this is in use Dec 4, 2023
@markphelps markphelps added the lg Little bit big label Dec 12, 2023
erka added a commit that referenced this issue Oct 21, 2024
erka added a commit that referenced this issue Oct 21, 2024
erka added a commit that referenced this issue Oct 21, 2024
* fix: don't allow to delete segment which is in use

related #2403 #3417
@erka erka closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants