-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLI-708] Warn user when trying to delete a segment this is in use #2403
Comments
Very reasonable. I think (since we addressed some feedback) that with the declarative backends you now get an error when validating your config when this referential constraint is violated. So this should only effect the relational backends. Just noting for the future given we implement fixing this. |
We plan to move segments to use Redux, much like @GeorgeMac did in #2301. I think doing that for segments and rules/rollouts might make fixing this much easier, as we could then cross reference each segment with flags/rules/rollouts at deletion time to do the check. will create issues for moving these resources to redux incase anyone is able to help there |
related #2403 #3417 Signed-off-by: Roman Dmytrenko <[email protected]>
related #2403 #3417 Signed-off-by: Roman Dmytrenko <[email protected]>
Problem
There is no indication to the user trying to delete a segment how the operation will affect the flags.
Ideal Solution
A message in the delete modal that highlights for the user that the segment being deleted is currently in use.
Something like "This flag is currently being used in 3 flags"
Search
Additional Context
No response
FLI-708
The text was updated successfully, but these errors were encountered: