[Bug]: Update button in Rule is not working

[satoren]

Bug Description

After changing the Rule of Variant type and pressing the Update button,
I get a toast saying that I succeeded, but nothing is reflected.

Version Info

v1.28.1

Search

• I searched for other open and closed issues before opening this

Steps to Reproduce

1. create flag as Variant
2. create segment
3. create two variants a and b in flag
4. add rule as Single Variant with a
5. change Variant a to b and press update button

a.mov

Expected Behavior

Changes will be reflected

Additional Context

No response

[GeorgeMac]

Thanks for bringing this issue in @satoren ! And the video and repro are super helpful. I will dig into this shortly.

[GeorgeMac]

Yep, I have replicated it exactly as described. I will dig into this some more.

Popping open the console I don't see any requests going to the backend.
Seems to suggest the issue is isolated to the frontend.

[GeorgeMac]

I have a feeling this big old TODO is related:

flipt/ui/src/components/rules/forms/QuickEditRuleForm.tsx

Lines 134 to 155 in 5736675

	// TODO: enable once we allow user to change variant of existing single dist rule
	// } else if (ruleType === DistributionType.Single && selectedVariant) {
	// // update variant if changed
	// if (rule.rollouts[0].distribution.variantId !== selectedVariant.id) {
	// try {
	// await updateDistribution(
	// namespace.key,
	// flag.key,
	// rule.id,
	// rule.rollouts[0].distribution.id,
	// {
	// variantId: selectedVariant.id,
	// rollout: 100
	// }
	// );
	// } catch (err) {
	// setError(err as Error);
	// return;
	// }
	// }
	// }

Going to wait for @markphelps @yquansah to come online and perhaps give some backstory.

[markphelps]

yeah, i dont think there was any well defined reason why we dont allow this. I just know that on the server side it is checked for and we have a TODO there as well: https:/flipt-io/flipt/blob/main/internal/storage/sql/common/rule.go#L685C1-L685C1

We have an internal issue tracking this (FLI-497). Perhaps is time we just go ahead and fix these TODOs on both the backend and frontend, as its been a while and no reasons why this should be dis-allowed have come to mind.