Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distributions): support updating distribution variant #2235

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Oct 13, 2023

Fixes #2231

This adds support for updating rule distribution variants on the server side.
It then also uncomments the code that adds this capability into the UI.

The majority of the PR is updates to tests:

  • unit tests for update distribution
  • integration tests for the API
  • playwright tests to ensure variant can be updated

@GeorgeMac GeorgeMac temporarily deployed to uffizzi October 13, 2023 13:18 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Uffizzi Preview deployment-38527 was deleted.

@GeorgeMac GeorgeMac temporarily deployed to uffizzi October 13, 2023 13:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2235 (e711a76) into main (61a91b6) will not change coverage.
The diff coverage is n/a.

❗ Current head e711a76 differs from pull request most recent head d589efc. Consider uploading reports for the commit d589efc to get more accurate results

@@           Coverage Diff           @@
##             main    #2235   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files          77       77           
  Lines        7307     7307           
=======================================
  Hits         5177     5177           
  Misses       1831     1831           
  Partials      299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GeorgeMac GeorgeMac temporarily deployed to uffizzi October 13, 2023 14:08 — with GitHub Actions Inactive
@GeorgeMac GeorgeMac temporarily deployed to uffizzi October 13, 2023 14:17 — with GitHub Actions Inactive
@GeorgeMac GeorgeMac temporarily deployed to uffizzi October 13, 2023 14:27 — with GitHub Actions Inactive
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you!!

@GeorgeMac GeorgeMac enabled auto-merge (squash) October 16, 2023 09:17
@GeorgeMac GeorgeMac merged commit 3128ac3 into main Oct 16, 2023
27 checks passed
@GeorgeMac GeorgeMac deleted the gm/update-dist-variant branch October 16, 2023 09:31
@GeorgeMac GeorgeMac temporarily deployed to uffizzi October 16, 2023 09:31 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Update button in Rule is not working
3 participants