[image_picker_android] - will fix crash on Android 12+ devices #6691
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Will need a test, though (you'd probably want to add a case in |
|
Test LGTM, are you able to add the autosubmit label (I can't remember what permissions non-member contributors have)? If yes feel free to land at your convenience, otherwise let me know and I can land it |
|
@gmackall Unfortunately I don't have permission to add autosubmit label. |
gmackall
added
the
autosubmit
|
auto label is removed for flutter/packages/6691, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
gmackall
added
the
autosubmit
|
FYI this only fixed the get-media codepath. |
flutter/packages@6c4482a...1412041 2024-05-13 [email protected] [in_app_purchase] Update country code Android example (flutter/packages#6722) 2024-05-13 [email protected] Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723) 2024-05-13 [email protected] [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629) 2024-05-13 [email protected] [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707) 2024-05-12 [email protected] Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715) 2024-05-11 [email protected] Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713) 2024-05-10 [email protected] [quick_actions] Add Swift Package Manager support (flutter/packages#6682) 2024-05-10 [email protected] [url_launcher] Add Swift Package Manager support (flutter/packages#6677) 2024-05-10 [email protected] [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499) 2024-05-10 [email protected] [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691) 2024-05-10 [email protected] [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697) 2024-05-10 [email protected] Update .gitignore for Swift Package Manager (flutter/packages#6705) 2024-05-10 [email protected] [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638) 2024-05-10 [email protected] [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708) 2024-05-10 [email protected] Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706) 2024-05-09 [email protected] [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This will fix flutter/flutter#147280
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.